supa_mdx_lint/
fix.rs

Help
use std::{borrow::Cow, cmp::Ordering, fs};

use anyhow::Result;
use bon::bon;
use log::{debug, error, trace};
use serde::{Deserialize, Serialize};

use crate::{
    app_error::AppError,
    context::Context,
    geometry::{AdjustedRange, DenormalizedLocation},
    output::LintOutput,
    rope::Rope,
    utils::{
        words::{is_sentence_start, WordIterator},
        Offsets,
    },
    Linter,
};

#[derive(Debug, Clone, Eq, PartialEq, Deserialize, Serialize)]
pub enum LintCorrection {
    Insert(LintCorrectionInsert),
    Delete(LintCorrectionDelete),
    Replace(LintCorrectionReplace),
}

#[derive(Debug, Clone, Eq, PartialEq, Deserialize, Serialize)]
pub struct LintCorrectionInsert {
    /// Text is inserted in front of the start point. The end point is ignored.
    pub(crate) location: DenormalizedLocation,
    pub(crate) text: String,
}

#[derive(Debug, Clone, Eq, PartialEq, Deserialize, Serialize)]
pub struct LintCorrectionDelete {
    pub(crate) location: DenormalizedLocation,
}

#[derive(Debug, Clone, Eq, PartialEq, Deserialize, Serialize)]
pub struct LintCorrectionReplace {
    pub(crate) location: DenormalizedLocation,
    pub(crate) text: String,
}

impl Offsets for LintCorrectionInsert {
    fn start(&self) -> usize {
        self.location.offset_range.start.into()
    }

    fn end(&self) -> usize {
        self.location.offset_range.end.into()
    }
}

impl LintCorrectionInsert {
    pub fn text(&self) -> &str {
        &self.text
    }
}

impl Offsets for LintCorrectionDelete {
    fn start(&self) -> usize {
        self.location.offset_range.start.into()
    }

    fn end(&self) -> usize {
        self.location.offset_range.end.into()
    }
}

impl Offsets for LintCorrectionReplace {
    fn start(&self) -> usize {
        self.location.offset_range.start.into()
    }

    fn end(&self) -> usize {
        self.location.offset_range.end.into()
    }
}

impl LintCorrectionReplace {
    pub fn text(&self) -> &str {
        &self.text
    }
}

impl PartialOrd for LintCorrection {
    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
        Some(self.cmp(other))
    }
}

impl Ord for LintCorrection {
    fn cmp(&self, other: &Self) -> std::cmp::Ordering {
        match (self, other) {
            (LintCorrection::Insert(insert_a), LintCorrection::Insert(insert_b)) => {
                insert_a.location.start.cmp(&insert_b.location.start)
            }
            (LintCorrection::Insert(insert), LintCorrection::Delete(delete)) => {
                if delete.location.start.le(&insert.location.start)
                    && delete.location.end.gt(&insert.location.start)
                {
                    // The delete wraps the insert, so only one of these fixes
                    // should take place. Represent this as equality.
                    return Ordering::Equal;
                }

                // The two don't overlap, so the delete is either fully before
                // or fully after the insert. We can arbitrarily choose between
                // the start and the end point for comparison.
                delete.location.start.cmp(&insert.location.start)
            }
            (LintCorrection::Insert(insert), LintCorrection::Replace(replace)) => {
                if replace.location.start.le(&insert.location.start)
                    && replace.location.end.gt(&insert.location.start)
                {
                    // The replace wraps the insert, so only one of these fixes
                    // should take place. Represent this as equality.
                    return Ordering::Equal;
                }

                // The two don't overlap, so the replace is either fully before
                // or fully after the insert. We can arbitrarily choose between
                // the start and the end point for comparison.
                replace.location.start.cmp(&insert.location.start)
            }
            (LintCorrection::Delete(_), LintCorrection::Insert(_)) => other.cmp(self).reverse(),
            (LintCorrection::Delete(delete_a), LintCorrection::Delete(delete_b)) => {
                let flip = delete_a.location.start.gt(&delete_b.location.start);
                if flip {
                    return other.cmp(self).reverse();
                }

                if delete_a.location.end.gt(&delete_b.location.start) {
                    // The deletes overlap either fully or partially, so only
                    // one overall fix should take place. Represent this as
                    // equality.
                    return Ordering::Equal;
                }

                Ordering::Less
            }
            (LintCorrection::Delete(delete), LintCorrection::Replace(replace)) => {
                let flip = delete.location.start.gt(&replace.location.start);
                if flip {
                    return other.cmp(self).reverse();
                }

                if delete.location.end.gt(&replace.location.start) {
                    // The deletes overlap either fully or partially, so only
                    // one overall fix should take place. Represent this as
                    // equality.
                    return Ordering::Equal;
                }

                Ordering::Less
            }
            (LintCorrection::Replace(_), LintCorrection::Insert(_)) => other.cmp(self).reverse(),
            (LintCorrection::Replace(replace), LintCorrection::Delete(delete)) => {
                let flip = replace.location.start.gt(&delete.location.start);
                if flip {
                    return other.cmp(self).reverse();
                }

                if replace.location.end.gt(&delete.location.start) {
                    // The ranges overlap either fully or partially, so only
                    // one overall fix should take place. Represent this as
                    // equality.
                    return Ordering::Equal;
                }

                Ordering::Less
            }
            (LintCorrection::Replace(replace_a), LintCorrection::Replace(replace_b)) => {
                let flip = replace_a.location.start.gt(&replace_b.location.start);
                if flip {
                    return other.cmp(self).reverse();
                }

                if replace_a.location.end.gt(&replace_b.location.start) {
                    // The ranges overlap either fully or partially, so only
                    // one overall fix should take place. Represent this as
                    // equality.
                    return Ordering::Equal;
                }

                Ordering::Less
            }
        }
    }
}

#[bon]
impl LintCorrection {
    /// Given two conflicting fixes, choose one to apply, or create a new fix
    /// that merges the two. Returns `None` if the's not clear which one to
    /// apply.
    ///
    /// Should only be called after checking that the fixes do in fact conflict.
    fn choose_or_merge(self, other: Self) -> Option<Self> {
        match (self, other) {
            (LintCorrection::Insert(_), LintCorrection::Insert(_)) => {
                // The fixes conflict and it's not clear which one to apply.
                // Inserting multiple alternate texts in the same place is
                // likely a mistake.
                None
            }
            (LintCorrection::Insert(_), LintCorrection::Delete(delete)) => {
                // The delete overlaps the insert, so apply the delete.
                Some(LintCorrection::Delete(delete))
            }
            (LintCorrection::Insert(_), LintCorrection::Replace(replace)) => {
                // The replace overlaps the insert, so apply the replace.
                Some(LintCorrection::Replace(replace))
            }
            (LintCorrection::Delete(delete), LintCorrection::Insert(_)) => {
                // The delete overlaps the insert, so apply the delete.
                Some(LintCorrection::Delete(delete))
            }
            (LintCorrection::Delete(delete_a), LintCorrection::Delete(delete_b)) => {
                // The deletes overlap, so merge them.
                let new_range = AdjustedRange::span_between(
                    &delete_a.location.offset_range,
                    &delete_b.location.offset_range,
                );
                let start = if delete_a.location.offset_range.start
                    < delete_b.location.offset_range.start
                {
                    delete_a.location.start
                } else {
                    delete_b.location.start
                };
                let end = if delete_a.location.offset_range.end > delete_b.location.offset_range.end
                {
                    delete_a.location.end
                } else {
                    delete_b.location.end
                };
                let location = DenormalizedLocation {
                    offset_range: new_range,
                    start,
                    end,
                };

                Some(LintCorrection::Delete(LintCorrectionDelete { location }))
            }
            (LintCorrection::Delete(delete), LintCorrection::Replace(replace)) => {
                // If one completely overlaps the other, apply it. Otherwise,
                // return None.
                if delete.location.start.lt(&replace.location.start)
                    && delete.location.end.gt(&replace.location.end)
                {
                    // The delete wraps the replace, so apply the delete.
                    Some(LintCorrection::Delete(delete))
                } else if replace.location.start.lt(&delete.location.start)
                    && replace.location.end.gt(&delete.location.end)
                {
                    // The replace wraps the delete, so apply the replace.
                    Some(LintCorrection::Replace(replace))
                } else {
                    None
                }
            }
            (LintCorrection::Replace(replace), LintCorrection::Insert(_)) => {
                // The replace overlaps the insert, so apply the replace.
                Some(LintCorrection::Replace(replace))
            }
            (LintCorrection::Replace(replace), LintCorrection::Delete(delete)) => {
                // If one completely overlaps the other, apply it. Otherwise,
                // return None.
                if delete.location.start.lt(&replace.location.start)
                    && delete.location.end.gt(&replace.location.end)
                {
                    // The delete wraps the replace, so apply the delete.
                    Some(LintCorrection::Delete(delete))
                } else if replace.location.start.lt(&delete.location.start)
                    && replace.location.end.gt(&delete.location.end)
                {
                    // The replace wraps the delete, so apply the replace.
                    Some(LintCorrection::Replace(replace))
                } else {
                    None
                }
            }
            (LintCorrection::Replace(replace_a), LintCorrection::Replace(replace_b)) => {
                // If one completely overlaps the other, apply it. Otherwise,
                // return None.
                if replace_b.location.start.lt(&replace_a.location.start)
                    && replace_b.location.end.gt(&replace_a.location.end)
                {
                    // The replace_b wraps the replace_a, so apply the replace_b.
                    Some(LintCorrection::Replace(replace_b))
                } else if replace_a.location.start.lt(&replace_b.location.start)
                    && replace_a.location.end.gt(&replace_b.location.end)
                {
                    // The replace_a wraps the replace_b, so apply the replace_a.
                    Some(LintCorrection::Replace(replace_a))
                } else {
                    None
                }
            }
        }
    }

    #[builder]
    pub(crate) fn create_word_splice_correction(
        context: &Context<'_>,
        outer_range: &AdjustedRange,
        splice_range: &AdjustedRange,
        #[builder(default = true)] count_beginning_as_sentence_start: bool,
        replace: Option<Cow<'_, str>>,
    ) -> Self {
        let outer_text = context.rope().byte_slice(outer_range.to_usize_range());
        let is_sentence_start = is_sentence_start()
            .slice(outer_text)
            .query_offset(splice_range.start.into_usize() - outer_range.start.into_usize())
            .count_beginning_as_sentence_start(count_beginning_as_sentence_start)
            .call();

        let location = DenormalizedLocation::from_offset_range(splice_range.clone(), context);

        match replace {
            Some(replace) => {
                let replace = if is_sentence_start {
                    replace.chars().next().unwrap().to_uppercase().to_string() + &replace[1..]
                } else {
                    replace.to_string()
                };

                LintCorrection::Replace(LintCorrectionReplace {
                    location,
                    text: replace,
                })
            }
            None => {
                let mut iter = WordIterator::new(
                    context.rope().byte_slice(splice_range.end.into_usize()..),
                    splice_range.end.into(),
                    Default::default(),
                );

                if let Some((offset, _, _)) = iter.next() {
                    let mut between = context
                        .rope()
                        .byte_slice(splice_range.end.into()..offset)
                        .chars();
                    if between.all(|c| c.is_whitespace()) {
                        if is_sentence_start {
                            let location = DenormalizedLocation::from_offset_range(
                                AdjustedRange::new(splice_range.start, (offset + 1).into()),
                                context,
                            );
                            LintCorrection::Replace(LintCorrectionReplace {
                                location,
                                text: context
                                    .rope()
                                    .byte_slice(offset..)
                                    .chars()
                                    .next()
                                    .unwrap()
                                    .to_string()
                                    .to_uppercase(),
                            })
                        } else {
                            LintCorrection::Delete(LintCorrectionDelete {
                                location: DenormalizedLocation::from_offset_range(
                                    AdjustedRange::new(splice_range.start, offset.into()),
                                    context,
                                ),
                            })
                        }
                    } else {
                        LintCorrection::Delete(LintCorrectionDelete { location })
                    }
                } else {
                    LintCorrection::Delete(LintCorrectionDelete { location })
                }
            }
        }
    }
}

impl Linter {
    /// Auto-fix any fixable errors.
    ///
    /// Returns a tuple of (number of files fixed, number of errors fixed).
    pub fn fix(&self, diagnostics: &[LintOutput]) -> Result<(usize, usize)> {
        let mut files_fixed: usize = 0;
        let mut errors_fixed: usize = 0;

        let fixable_outputs: Vec<&LintOutput> = diagnostics
            .iter()
            .filter(|diagnostic| diagnostic.errors().iter().any(|error| error.fix.is_some()))
            .collect();
        if fixable_outputs.is_empty() {
            debug!("No fixable errors found for this set of diagnostics.");
            trace!("Diagnostics: {:#?}", diagnostics);
            return Ok((files_fixed, errors_fixed));
        }

        for diagnostic in fixable_outputs {
            let local_errors_fixed = Self::fix_single_file(diagnostic).inspect_err(|err| {
                error!("Error fixing file {}: {}", diagnostic.file_path(), err)
            })?;
            errors_fixed += local_errors_fixed;
            files_fixed += 1;
        }

        Ok((files_fixed, errors_fixed))
    }

    fn fix_single_file(diagnostic: &LintOutput) -> Result<usize> {
        let mut errors_fixed = 0;

        let file = diagnostic.file_path();
        debug!("Fixing errors in {file}");

        let content = fs::read_to_string(file).map_err(|err| {
            AppError::FileSystemError(format!("reading file {file} for auto-fixing"), err)
        })?;
        let mut rope = Rope::from(content.as_str());

        let fixes_to_apply = Self::calculate_fixes_to_apply(file, diagnostic);
        debug!("Fixes to apply for file {file}: {fixes_to_apply:#?}");

        for fix in fixes_to_apply {
            match fix {
                LintCorrection::Insert(lint_fix_insert) => {
                    rope.insert(
                        lint_fix_insert.location.offset_range.start.into(),
                        lint_fix_insert.text,
                    );
                    errors_fixed += 1;
                }
                LintCorrection::Delete(lint_fix_delete) => {
                    let start: usize = lint_fix_delete.location.offset_range.start.into();
                    let end: usize = lint_fix_delete.location.offset_range.end.into();
                    rope.replace(start..end, "");
                    errors_fixed += 1;
                }
                LintCorrection::Replace(lint_fix_replace) => {
                    let start: usize = lint_fix_replace.location.offset_range.start.into();
                    let end: usize = lint_fix_replace.location.offset_range.end.into();
                    rope.replace(start..end, lint_fix_replace.text.as_str());
                    errors_fixed += 1;
                }
            }
        }

        let content = rope.to_string();
        fs::write(diagnostic.file_path(), content).map_err(|err| {
            AppError::FileSystemError(format!("writing file {file} post-fixing"), err)
        })?;

        Ok(errors_fixed)
    }

    fn calculate_fixes_to_apply(file: &str, diagnostic: &LintOutput) -> Vec<LintCorrection> {
        let mut requested_fixes: Vec<LintCorrection> = diagnostic
            .errors()
            .iter()
            .filter_map(|err| err.fix.clone())
            .flatten()
            .collect();
        requested_fixes.sort();
        // Reversing so that fixes are applied in reverse order, avoiding
        // offset shift.
        let requested_fixes = requested_fixes.into_iter().rev();
        debug!("Requested fixes for file {file}: {requested_fixes:#?}");

        let mut fixes_to_apply: Vec<LintCorrection> = Vec::new();
        for fix in requested_fixes {
            if let Some(last_scheduled_fix) = fixes_to_apply.last() {
                if last_scheduled_fix.eq(&fix) {
                    // The fixes conflict, so pick one to fix, or merge
                    // them.
                    let last_scheduled_fix = fixes_to_apply.pop().unwrap();
                    if let Some(new_fix) = last_scheduled_fix.choose_or_merge(fix) {
                        fixes_to_apply.push(new_fix);
                    }
                } else {
                    // The fixes don't conflict, so apply both.
                    fixes_to_apply.push(fix.clone());
                }
            } else {
                fixes_to_apply.push(fix.clone());
            }
        }

        fixes_to_apply
    }
}

#[cfg(test)]
mod tests {
    use crate::parse;

    use super::*;

    #[test]
    fn test_create_word_splice_correction_midsentence() {
        let parsed = parse("Here is a simple sentence.").unwrap();
        let context = Context::builder().parse_result(&parsed).build().unwrap();

        let outer_range = AdjustedRange::new(0.into(), 26.into());
        let splice_range = AdjustedRange::new(10.into(), 16.into());

        let expected = LintCorrection::Delete(LintCorrectionDelete {
            location: DenormalizedLocation::from_offset_range(
                AdjustedRange::new(10.into(), 17.into()),
                &context,
            ),
        });
        let actual = LintCorrection::create_word_splice_correction()
            .context(&context)
            .outer_range(&outer_range)
            .splice_range(&splice_range)
            .call();
        assert_eq!(expected, actual);
    }

    #[test]
    fn test_create_word_splice_correction_midsentence_replace() {
        let parsed = parse("Here is a simple sentence.").unwrap();
        let context = Context::builder().parse_result(&parsed).build().unwrap();

        let outer_range = AdjustedRange::new(0.into(), 26.into());
        let splice_range = AdjustedRange::new(10.into(), 16.into());

        let expected = LintCorrection::Replace(LintCorrectionReplace {
            text: "lovely".to_string(),
            location: DenormalizedLocation::from_offset_range(
                AdjustedRange::new(10.into(), 16.into()),
                &context,
            ),
        });
        let actual = LintCorrection::create_word_splice_correction()
            .context(&context)
            .outer_range(&outer_range)
            .splice_range(&splice_range)
            .replace("lovely".into())
            .call();
        assert_eq!(expected, actual);
    }

    #[test]
    fn test_create_word_splice_correction_new_sentence() {
        let parsed = parse("What a lovely day. Please take a biscuit.").unwrap();
        let context = Context::builder().parse_result(&parsed).build().unwrap();

        let outer_range = AdjustedRange::new(0.into(), 41.into());
        let splice_range = AdjustedRange::new(19.into(), 25.into());

        let expected = LintCorrection::Replace(LintCorrectionReplace {
            text: "T".to_string(),
            location: DenormalizedLocation::from_offset_range(
                AdjustedRange::new(19.into(), 27.into()),
                &context,
            ),
        });
        let actual = LintCorrection::create_word_splice_correction()
            .context(&context)
            .outer_range(&outer_range)
            .splice_range(&splice_range)
            .call();
        assert_eq!(expected, actual);
    }

    #[test]
    fn test_create_word_splice_correction_new_sentence_replace() {
        let parsed = parse("What a lovely day. Please take a biscuit.").unwrap();
        let context = Context::builder().parse_result(&parsed).build().unwrap();

        let outer_range = AdjustedRange::new(0.into(), 41.into());
        let splice_range = AdjustedRange::new(19.into(), 25.into());

        let expected = LintCorrection::Replace(LintCorrectionReplace {
            text: "Kindly".to_string(),
            location: DenormalizedLocation::from_offset_range(
                AdjustedRange::new(19.into(), 25.into()),
                &context,
            ),
        });
        let actual = LintCorrection::create_word_splice_correction()
            .context(&context)
            .outer_range(&outer_range)
            .splice_range(&splice_range)
            .replace("kindly".into())
            .call();
        assert_eq!(expected, actual);
    }

    #[test]
    fn test_create_word_splice_correction_start() {
        let parsed = parse("Please take a biscuit.").unwrap();
        let context = Context::builder().parse_result(&parsed).build().unwrap();

        let outer_range = AdjustedRange::new(0.into(), 22.into());
        let splice_range = AdjustedRange::new(0.into(), 6.into());

        let expected = LintCorrection::Replace(LintCorrectionReplace {
            text: "T".to_string(),
            location: DenormalizedLocation::from_offset_range(
                AdjustedRange::new(0.into(), 8.into()),
                &context,
            ),
        });
        let actual = LintCorrection::create_word_splice_correction()
            .context(&context)
            .outer_range(&outer_range)
            .splice_range(&splice_range)
            .call();
        assert_eq!(expected, actual);
    }
}
supa_mdx_lint/fix.rs

supa_mdx_lint/
fix.rs
